| Steve O'Brien |
 |
Posted Sep 25, 2015 at 5:43 AM Our league is set to auto-pick with 21 auto-picks allowed and players not allowed to configure own auto-pick. When the Thursday 8:00pm deadline passes, players who have not picked get marked as No Pick instead of being assigned the team with the biggest spread. This has happened the first two weeks after I changed to use auto-pick. I manually made the picks for those people, but I would like auto-pick to work in the future if possible. Is there anything I am missing? Thanks. Edit: One more strange thing. The first week we did auto-pick (week 2), one person got their pick made for them, but it didn't work for two other people. Last week, both of the people who didn't pick got marked as No Pick. The only difference I can see with the one that worked was that they didn't make an incorrect pick the previous week (we have 1 buyback). I had approved all the buybacks so everybody was active, but it might have something to do with an incorrect pick followed by an auto-pick. Steve |
| Fred Williams |
 The Commish Age: 62 850 Posts |
Posted Sep 25, 2015 at 9:09 AM  Steve O'Brien wrote: Our league is set to auto-pick with 21 auto-picks allowed and players not allowed to configure own auto-pick. When the Thursday 8:00pm deadline passes, players who have not picked get marked as No Pick instead of being assigned the team with the biggest spread. This has happened the first two weeks after I changed to use auto-pick. I manually made the picks for those people, but I would like auto-pick to work in the future if possible. Is there anything I am missing? Thanks. Edit: One more strange thing. The first week we did auto-pick (week 2), one person got their pick made for them, but it didn't work for two other people. Last week, both of the people who didn't pick got marked as No Pick. The only difference I can see with the one that worked was that they didn't make an incorrect pick the previous week (we have 1 buyback). I had approved all the buybacks so everybody was active, but it might have something to do with an incorrect pick followed by an auto-pick. Steve
Hi Steve, I tracked it down to some logic related with buyback, so your observation was spot on. I should have a fix sometime today or tomorrow so no need to submit picks for them. Thanks for letting me know. Fred
"I want to die peacefully in my sleep like my grandfather, not screaming in terror like his passengers!" |
| Steve O'Brien |
|
Posted Sep 25, 2015 at 9:28 AM That's great. Thanks! One more thing you might consider in the future. When I was running my own league using a spreadsheet, I would always send out a list of everybody's picks to the people who were still in the pool so you could see the final picks without bringing up the spreadsheet (or going to the website in this case). It might be nice to have an option to send the picks to all active players after the pick deadline has passed. That way everybody will know instantly what picks were made and they would also have a copy of the picks that they could bring up on their phones on Sunday. Maybe even another option to automatically send out the results after all games are complete. Great site! Steve |
| Fred Williams |
The Commish Age: 62 850 Posts |
Posted Sep 25, 2015 at 7:57 PM Steve O'Brien wrote: That's great. Thanks! One more thing you might consider in the future. When I was running my own league using a spreadsheet, I would always send out a list of everybody's picks to the people who were still in the pool so you could see the final picks without bringing up the spreadsheet (or going to the website in this case). It might be nice to have an option to send the picks to all active players after the pick deadline has passed. That way everybody will know instantly what picks were made and they would also have a copy of the picks that they could bring up on their phones on Sunday. Maybe even another option to automatically send out the results after all games are complete. Great site! Steve
I'll put this on the list, but it would probably have to be an option that the manager has to go in and initiate each week. The reason I'm nervous of something like this is because too many emails coming from a server can cause that server to be marked as spam. I'm looking at the auto-pick now. I'm a little concerned because there is a comment in the code that explicitiy says to not do an autopick if buybacks are enabled and the person lost the week before. I'm going to have to spend some time looking at the file history to see what if any reason this was done this way. Fred
"I want to die peacefully in my sleep like my grandfather, not screaming in terror like his passengers!" |
| Fred Williams |
The Commish Age: 62 850 Posts |
Posted Sep 25, 2015 at 8:10 PM Fred Williams wrote: Steve O'Brien wrote: That's great. Thanks! One more thing you might consider in the future. When I was running my own league using a spreadsheet, I would always send out a list of everybody's picks to the people who were still in the pool so you could see the final picks without bringing up the spreadsheet (or going to the website in this case). It might be nice to have an option to send the picks to all active players after the pick deadline has passed. That way everybody will know instantly what picks were made and they would also have a copy of the picks that they could bring up on their phones on Sunday. Maybe even another option to automatically send out the results after all games are complete. Great site! Steve
I'll put this on the list, but it would probably have to be an option that the manager has to go in and initiate each week. The reason I'm nervous of something like this is because too many emails coming from a server can cause that server to be marked as spam. I'm looking at the auto-pick now. I'm a little concerned because there is a comment in the code that explicitiy says to not do an autopick if buybacks are enabled and the person lost the week before. I'm going to have to spend some time looking at the file history to see what if any reason this was done this way. Fred
OK, I figured out why the code prevents auto-pick for a player who lost the prior week. This was to prevent an autopick for a player in a league that is not configured for manager approval of the buyback. What was happening is that players who didn't want to buyback were having a pick made for them anyway. So, the way around this is to only do this autopick blocking logic if the league is not configured for manager approval of the buyback. Fred
"I want to die peacefully in my sleep like my grandfather, not screaming in terror like his passengers!" |
| Steve O'Brien |
|
Posted Sep 25, 2015 at 8:17 PM Fred -
Completely understand about too many emails going out. With the auto-pick issue, I suppose the only way to be sure that they are really back in the pool is if the status always goes to something other than active when a players has an incorrect pick. That way, as long as the player is active, you would know the league manager assigned that status. But I have approve buyback as yes, so I don't know how it would work if it was set to no. I could definitely see how it would cause problems. Anyways, thanks for taking the time to reply.
Steve |
| Fred Williams |
The Commish Age: 62 850 Posts |
Posted Sep 25, 2015 at 8:32 PM Steve O'Brien wrote:
Completely understand about too many emails going out. With the auto-pick issue, I suppose the only way to be sure that they are really back in the pool is if the status always goes to something other than active when a players has an incorrect pick. That way, as long as the player is active, you would know the league manager assigned that status. But I have approve buyback as yes, so I don't know how it would work if it was set to no. I could definitely see how it would cause problems. Anyways, thanks for taking the time to reply.
Steve
OK, I just finished testing the change on the test site. The fix is now on the production site, though I notice that you haven't approved the buyback for two of the players with 'No Pick' showing, which might be your intent anyway. If they do a buyback and you approve they'll be assigned the autopick. Fred
"I want to die peacefully in my sleep like my grandfather, not screaming in terror like his passengers!" |
| Steve O'Brien |
|
Posted Sep 26, 2015 at 4:44 AM Thank you very much for your help. If it helps with your testing, the two people who are still marked as buyback pending didn't want to buy back. I left them in that state per the site's instructions. The two people who had their picks auto-picked both bought back in and I changed their status from buyback pending to active. Those were the two people I had to manually change. Thanks again.
Steve |